fix language-not-found issues on repo page with simplified and traditional Chinese #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional Chinese The author of github-readme-stats uses the non-standard code "cn" for simplified Chinese, see [here](https://github.com/anuraghazra/github-readme-stats?tab=readme-ov-file#available-locales). While for traditional Chinese the author only provides "zh-tw". The github-readme-stats functions on repo page will break if the user sets the site language to ALL variants of Chinese except for zh-tw. This hack is to make all sub-variants of simplified Chinese fall back to "cn" and all sub-variants of traditional Chinese fall back to "zh-tw".
✅ Deploy Preview for relaxed-lollipop-b6bc17 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
george-gca
approved these changes
Feb 13, 2025
try to satisfy Prettier requirement
george-gca
requested changes
Feb 14, 2025
switch to the `case-when` structure to make code eaiser to maintain in the future.
switch to the `case-when` structure to make code eaiser to maintain in the future.
george-gca
requested changes
Feb 14, 2025
|
You should use Line 18 in 10d007a Also, you are missing the use of the |
|
Implemented the requested changes. |
implemented the requested change
implemented the requested change
fixed a typo
george-gca
requested changes
Feb 14, 2025
impleted the requested change
implemented the requested change
george-gca
approved these changes
Feb 14, 2025
tried my best to make prettier happy...
tried my best to make prettier happy...
george-gca
approved these changes
Feb 14, 2025
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The author of github-readme-stats uses the non-standard code "cn" for simplified Chinese, see here. While for traditional Chinese the author only provides "zh-tw". The github-readme-stats functions on repo page will break if the user sets the site language to ALL variants of Chinese except for zh-tw. This hack is to make all sub-variants of simplified Chinese fall back to "cn" and all sub-variants of traditional Chinese fall back to "zh-tw".
This patch fixes the problem and has been tested locally & with GitHub pages.