Adding inject as AMD compliant loader #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was going to be sending this to the mailing list as well, but I'd like to formally submit a pull request for inject, a Library we've been working on at LinkedIn for managing our dependencies. At a high level, we wanted a CommonJS compliant loader. Somewhere along the line, we also added in the AMD support, so we'd like to offer it as a listing for a browser side solution that works with both wrapped and unwrapped modules.
Its main features:
We're really proud to be putting this out as a solution for script loading, and want to help get behind some of the standards as they emerge. We are currently passing all tests, but have opted out of the two
plugin
modules.Feedback is very welcome as we continue to build this out. Our hope is to begin using this at the core of LinkedIn to simplify our JavaScript framework greatly.
Main repository: https://github.com/linkedin/inject