Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding inject as AMD compliant loader #5

Merged
merged 4 commits into from
Jan 21, 2012
Merged

Adding inject as AMD compliant loader #5

merged 4 commits into from
Jan 21, 2012

Conversation

thecodedrift
Copy link
Contributor

Hello,

I was going to be sending this to the mailing list as well, but I'd like to formally submit a pull request for inject, a Library we've been working on at LinkedIn for managing our dependencies. At a high level, we wanted a CommonJS compliant loader. Somewhere along the line, we also added in the AMD support, so we'd like to offer it as a listing for a browser side solution that works with both wrapped and unwrapped modules.

Its main features:

  • XHR + eval for all functionality
  • Uses porthole for cross domain script loading
  • localStorage for in-client caching
  • AMD compliance for script tag rollups (useful in large payload sites)

We're really proud to be putting this out as a solution for script loading, and want to help get behind some of the standards as they emerge. We are currently passing all tests, but have opted out of the two plugin modules.

Feedback is very welcome as we continue to build this out. Our hope is to begin using this at the core of LinkedIn to simplify our JavaScript framework greatly.

Main repository: https://github.com/linkedin/inject

chaozhang and others added 4 commits December 21, 2011 17:34
Added the inject framework github.com/jakobo/inject, which will pass all AMD tests using XHR+eval solution.
using latest version of inject.js for amdjs-tests, and fix one small bug and pass all tests. Related to jakobo/inject#78
jrburke added a commit that referenced this pull request Jan 21, 2012
Adding inject as AMD compliant loader
@jrburke jrburke merged commit c2276aa into amdjs:master Jan 21, 2012
@jrburke
Copy link
Contributor

jrburke commented Jan 21, 2012

Great, thanks for the pull request. It has been merged. Please feel free to contact the amd-implement list to give them a low-down on the loader. You are probably already doing this, but you will likely want to track the list for changes in the tests over time.

@thecodedrift
Copy link
Contributor Author

Thanks. I think I sent a post to amd-implement, it's in the moderation queue. Quoted below:

Hello everyone,

I wanted to take a moment and announce to the list another AMD &
CommonJS Compliant loader: inject. We've been working on it internally
at LinkedIn for just the CommonJS side, and someone got the idea of
extending it to add AMD support. The results are pretty awesome. We've
put up the test suite at https://github.com/Jakobo/amdjs-tests, and
support the AMD spec except for the following

* No plugin support
* No dynamic plugin support

The wiki, sample code, and test suite for AMD made integration a
breeze. We've also sent a pull request over to the amd-tests
repository based on the passing test suite. We are really excited
about getting feedback on the project, as we're looking to see how
this technology can drive our JavaScript stack for the main
linkedin.com site and grow beyond the prototypes we have done.

You can find the main inject repository at https://github.com/linkedin/inject

Regards,
Jakob

@jrburke
Copy link
Contributor

jrburke commented Jan 21, 2012

Ugh, sorry I have not been receiving moderation emails. It is cleared out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants