-
Notifications
You must be signed in to change notification settings - Fork 13
many minor Outer Crateria fixes and tweaks #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I'm guessing the change to the palette for tileset $08 was a mistake? If so, can you revert that? Also the change to The changes to 16x16 tiles for tileset $00 would have actual conflicts; to resolve this, it may be simplest to checkout the file from the upstream and then reapply the change you made to the one tile. |
The palette change must've indeed been a mistake, sorry about that. I think all should be in order now, hopefully? Applying the tileset file from upstream, I did notice the Crateria tube tiles got messed up, but I'm not sure if that's just on my end or if it's even an issue in the first place. |
You may want to merge the upstream into your branch. It's expected that stuff would look messed up by pulling in only the updated 16x16 tiles without the corresponding 8x8 tiles which were also updated (on tileset $00 and on CRE and other tilesets) |
Ah, I see. I'm guessing it's fine to do that even while this PR is open and it's not going to cause problems? |
Yeah it should be fine. If you're using the GitHub UI just avoid selecting an option to "discard your commits". Let me know if you need any help with it. Really appreciate your work on this! |
Alright, I think I've got it now. Thanks for the guidance, and no problem! Happy to help. |
Looks like the tests are failing because the collision layer was modified in a few places. This is a common problem so no big deal. The tests are there to validate that no changes are made to the collision (relative to the Base project). If you open the test details, it will list the specific rooms & tiles that have an issue. |
Should be fixed now. |
Tileset:
Rooms:
AREA 0
AREA 1
AREA 2
AREA 3
AREA 4
AREA 5