Fix graphical issue with shot block items #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the Item Loading patch was working, after collecting a shot block item, after the shot block re-forms it was loading the item graphics again. If the player paused at some point in the room before this happens, then the item PLM graphics index ($1C2D) will have been reset to zero (a vanilla quirk), which could cause the graphics for a mismatched item to be reloaded. So that's what caused the issue in Mama Turtle Room that Kiara and Eddie saw.
There was no reason for the graphics to get reloaded in this situation. The fact that it happened was just an oversight in the patch, which this PR fixes.