Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Fbclid config option #338

Merged
merged 7 commits into from
Jan 6, 2021

Conversation

jarrenpatao
Copy link
Contributor

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@haoliu-amp
Copy link
Contributor

@jarrenpatao How did you test your PR btw?

@kelvin-lu
Copy link
Contributor

@jarrenpatao it looks like this is failing at the lint checks (@kelsonpw it's working super well!) - could you run yarn fix to make sure the code adhere's to the style format?

@jarrenpatao
Copy link
Contributor Author

@haoliu-amp I did create-react-app and yarn link an updated version of a cloned repo (7.3.3)

if (utils.isEmptyString(fbclid)) {
return;
}
var fbclidProperties = { fbclid: fbclid };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our practice is to add the quote? @kelvin-lu @jooohhn ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ this got updated with @kelsonpw's linting - if the key is a single word (e.g. not { 'fb click id': fbclid }), this will update to without quotes!

Copy link
Contributor

@kelvin-lu kelvin-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! This looks great and we'll talk about deploying this when we're back (it's planned for part of the deep dive to look at the improved build system @jooohhn created)

@jooohhn jooohhn merged commit f52288a into amplitude:master Jan 6, 2021
github-actions bot pushed a commit that referenced this pull request Jan 6, 2021
# [7.4.0](v7.3.3...v7.4.0) (2021-01-06)

### Features

* **privacy:** Add `storage` option ([#320](#320)) ([1a56a9b](1a56a9b)), closes [#317](#317)
* Added Fbclid config option ([#338](#338)) ([f52288a](f52288a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a includeFbclid option to configuration options
5 participants