Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: core package for seamless integration with amplitude analytics #15

Merged
merged 30 commits into from
Jan 26, 2022
Merged

feat: core package for seamless integration with amplitude analytics #15

merged 30 commits into from
Jan 26, 2022

Conversation

bgiori
Copy link
Collaborator

@bgiori bgiori commented Nov 18, 2021 •
edited
Loading

Summary

Add core package for integration with analytics SDK.

  • Keeps the same API as Android/iOS for AnalyticsConnector and IdentityStore
    • Changes the core singleton access to global/window in order to play nicely in the browser with potentially different script tags.
  • Package is pulled in as a dependency to experiment SDK and a dev dependency to the analytics SDK.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@bgiori bgiori marked this pull request as ready for review November 30, 2021 02:10
@bgiori bgiori mentioned this pull request Nov 30, 2021
Merged
1 task
@bgiori bgiori requested a review from curtisliu December 1, 2021 20:52
qingzhuozhen
qingzhuozhen reviewed Dec 3, 2021
View reviewed changes
packages/core/rollup.config.js
dir: 'dist',
entryFileNames: 'core.umd.js',
exports: 'named',
format: 'umd',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious is esm also supported?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add support for this later. High priority ATM but not blocking this release.

@calvinkcox-divvyhomes calvinkcox-divvyhomes mentioned this pull request Jan 17, 2022
Closed
@bgiori bgiori merged commit f62c4cb into main Jan 26, 2022
@bgiori bgiori deleted the core branch January 26, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-fiedler justin-fiedler justin-fiedler left review comments

@qingzhuozhen qingzhuozhen qingzhuozhen left review comments

@curtisliu curtisliu Awaiting requested review from curtisliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgiori @justin-fiedler @qingzhuozhen