Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add guard for navigator for use in envs that do no support navig… #36

Merged
merged 1 commit into from
Jun 23, 2022
Merged

fix: add guard for navigator for use in envs that do no support navig… #36

merged 1 commit into from
Jun 23, 2022

Conversation

kevinpagtakhan
Copy link
Contributor

…ator

Summary

Adds a check for navigator before accessing navigator.userAgent. Affects amplitude-js.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@kevinpagtakhan kevinpagtakhan requested a review from bgiori June 23, 2022 23:18
@bgiori bgiori merged commit 2c8d398 into main Jun 23, 2022
@bgiori bgiori deleted the AMP-55823-navigator-guard branch June 23, 2022 23:38
@kevinpagtakhan kevinpagtakhan mentioned this pull request Jun 23, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgiori bgiori bgiori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinpagtakhan @bgiori