Retargetting of slots proposal #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
reviewed
Sep 6, 2019
src/react-compat-base-element.js
Outdated
| // 1. `disabled` doesn't apply inside subtrees. This makes it more like | ||
| // `hidden`. | ||
| // 2. re-propagate events to slots since React stops propagation. | ||
| const disabled = slot.hasAttribute('disabled'); |
There was a problem hiding this comment.
Maybe we should be propagating all attributes?
There was a problem hiding this comment.
Yeah. We could. Or propagate only those that the element itself doesn't have. E.g. hidden is not needed to be propagated, disabled has to be, aria-label only if button itself doesn't specify it. I updated the code. Still a couple of questions there, but might be good enough to start with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO slots are a special class indirection. With a minor effort we are here able to propagate a few properties between the slot and target - or retarget in other words. This makes
disabledattribute work very similar tohidden.