fix(marker-display): error when changing resource #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amtins
force-pushed
the
fix/12-error-when-changing-source-during-playback
branch
from
122951d to
7507881
Compare
Fix #12 which occurred when loading resource after starting playback. This bug didn't cause any component malfunctions, apart from displaying errors in the console. - adds a guard clause to `updateMarker` to update the marker only if `getClientRects` is not empty
amtins
force-pushed
the
fix/12-error-when-changing-source-during-playback
branch
from
7507881 to
e8474d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #12 which occurred when loading resource after starting playback. This bug didn't cause any component malfunctions, apart from displaying errors in the console.
Changes made
updateMarkerto update the marker only ifgetClientRectsis not empty