feat(markers-display): displays the marker buffer #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature modifies the `MarkerDisplay` class to add support for displaying and updating the marker buffer at every progress event. - modifies the `updateMarker` function to take a `time` and a `css variable` as parameters - adds the `updateMarkerBuffered` function, which uses `updateMarker` to update the marker buffer - adds the `updateMarkerPlayed` function, which uses `updateMarker` to update the played marker - renames the `css variable` used to update the marker's buffering percentage - redefines the default color of `--cst-marker-buffered-background-color`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature modifies the
MarkerDisplayclass to add support for displaying and updating the marker buffer at every progress event.Screencast.from.01-13-24.16.46.24.webm
Changes made
updateMarkerfunction to take atimeand acss variableas parametersupdateMarkerBufferedfunction, which usesupdateMarkerto update the marker bufferupdateMarkerPlayedfunction, which usesupdateMarkerto update the played markercss variableused to update the marker's buffering percentage--cst-marker-buffered-background-color