Bug: Endless fetching on finite lists #216
Open
+9
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed some logical errors;
lastRequestedPage
incrementation is skipped if not going through therequestMore
so added to therequestAndSaveData
instead as it was leading to erroneous countingRequesting was endless even though the results might have been finite. Fixed by keeping the
totalItemCount
from the response and adding it to the condition of either to request more or not.Testing
orestis
)