fix(@schematics/angular): add migration to update web-animations-js…
#14539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
state: blocked
target: patch
alan-agius4
commented
May 28, 2019
packages/schematics/angular/migrations/update-8/update-dependencies.ts
Outdated
Show resolved
Hide resolved
|
Blocked on web-animations/web-animations-js#208 |
… polyfill Previous versions rely on `this` which breaks differential loading since it's `undefined` when using script tags with type module. Fixes #14518
alexeagle
approved these changes
May 28, 2019
|
unblocked this by publishing a release with Minko's fix to the angular fork of the project. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… polyfill
Previous versions rely on
thiswhich breaks differential loading since it'sundefinedwhen using script tags with type module.