Skip to content

feat(@angular-devkit/build-angular): initial development server for esbuild-based builder #24923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Mar 29, 2023

When using the experimental esbuild-based browser application builder, the preexisting dev-server builder can now be used to execute the ng serve command with an esbuild bundled application. The dev-server builder provides an alternate development server that will execute the browser-esbuild builder to build the application and then serve the output files within a development server with live reload capabilities. This is an initial integration of the development server. It is not yet fully optimized and all features may not yet be supported. SSL, in particular, does not yet work.

If already using the esbuild-based builder, no additional changes to the Angular configuration are required. The dev-server builder will automatically detect the application builder and use the relevent development server implementation. As the esbuild-based browser application builder is currently experimental, using the development server in this mode is also considered experimental.

@clydin clydin added the target: major This PR is targeted for the next major release label Mar 29, 2023
@clydin clydin marked this pull request as ready for review March 29, 2023 16:34
@clydin clydin requested a review from alan-agius4 March 29, 2023 16:34
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 29, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Mar 29, 2023
@clydin clydin force-pushed the esbuild/initial-dev-server branch 2 times, most recently from 33d4afb to f149f16 Compare March 29, 2023 17:59
…sbuild-based builder

When using the experimental esbuild-based browser application builder, the preexisting `dev-server` builder
can now be used to execute the `ng serve` command with an esbuild bundled application. The `dev-server` builder
provides an alternate development server that will execute the `browser-esbuild` builder to build the application
and then serve the output files within a development server with live reload capabilities.
This is an initial integration of the development server. It is not yet fully optimized and all features
may not yet be supported. SSL, in particular, does not yet work.

If already using the esbuild-based builder, no additional changes to the Angular configuration are required.
The `dev-server` builder will automatically detect the application builder and use the relevent development
server implementation. As the esbuild-based browser application builders is currently experimental, using
the development server in this mode is also considered experimental.
@jpike88
Copy link

jpike88 commented Mar 31, 2023

Complex project of ours is tested and building fine with the experimental esbuild implementation to date, looking forward to testing this!

@bryanerayner
Copy link

Does it still support deployUrl?

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 3, 2023
@angular-robot angular-robot bot merged commit 8c55030 into angular:main Apr 4, 2023
@clydin clydin deleted the esbuild/initial-dev-server branch April 4, 2023 11:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants