-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Upgrade build setup to node 5 + update all npm dependencies (especially karma) #13505
Comments
this is not time-critical but we should do it soonish. on or before Dec 21 is good. |
Node 5 comes with npm 3, which breaks our "purge node_modules in preinstall" workflow. This is tracked in #13123. The same issue should also affect ng2 (see angular/angular#5172). @IgorMinar, any ideas on how to tackle it on ng2 ? |
I'll work on nmp3 upgrade of ng2 in late december. If this is blocking then let's upgrade to node 4 first now and once ng2 is
|
Why do we need it for 1.3? I'd say more people are using 1.2 than 1.3. |
I think it is reasonable to ensure that our main branches are all building on the same environment. |
Here is a PR for using node 4 on Travis: #13552 |
We are on node 6 right now :D |
also can someone please prepare PRs to make master, 1.4.x, 1.3.x compatible with node 5? do not merge them, just prepare the PRs please. Ideally these three branches should have the same build setup and be always updated in sync so that it’s easy to jump between branches and cherry-pick commits
The text was updated successfully, but these errors were encountered: