Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Upgrade build setup to node 5 + update all npm dependencies (especially karma) #13505

Closed
3 tasks
IgorMinar opened this issue Dec 11, 2015 · 7 comments
Closed
3 tasks
Assignees
Milestone

Comments

@IgorMinar
Copy link
Contributor

also can someone please prepare PRs to make master, 1.4.x, 1.3.x compatible with node 5? do not merge them, just prepare the PRs please. Ideally these three branches should have the same build setup and be always updated in sync so that it’s easy to jump between branches and cherry-pick commits

  • master
  • 1.4.x
  • 1.3.x
@IgorMinar
Copy link
Contributor Author

this is not time-critical but we should do it soonish. on or before Dec 21 is good.

@gkalpak
Copy link
Member

gkalpak commented Dec 11, 2015

Node 5 comes with npm 3, which breaks our "purge node_modules in preinstall" workflow. This is tracked in #13123.

The same issue should also affect ng2 (see angular/angular#5172). @IgorMinar, any ideas on how to tackle it on ng2 ?

@IgorMinar
Copy link
Contributor Author

I'll work on nmp3 upgrade of ng2 in late december.

If this is blocking then let's upgrade to node 4 first now and once ng2 is
npm3 compatible we'll reuse the same approach here.
On Thu, Dec 10, 2015 at 9:44 PM Georgios Kalpakas [email protected]
wrote:

Node 5 comes with npm 3, which breaks our "purge node_modules in
preinstall" workflow. This is tracked in #13123
#13123.

The same issue should also affect ng2 (see angular/angular#5172
angular/angular#5172). @IgorMinar
https://github.com/IgorMinar, any ideas on how to tackle it on ng2 ?


Reply to this email directly or view it on GitHub
#13505 (comment)
.

@Narretz
Copy link
Contributor

Narretz commented Dec 11, 2015

Why do we need it for 1.3? I'd say more people are using 1.2 than 1.3.

@petebacondarwin
Copy link
Contributor

I think it is reasonable to ensure that our main branches are all building on the same environment.
This feels like a problem that only needs solving once and then we could roll it out across the board.
1.3 is a low priority for us but I think that there are still quite a few Google apps using that version. @IgorMinar could probably provide more detail.

@petebacondarwin
Copy link
Contributor

Here is a PR for using node 4 on Travis: #13552

@Narretz
Copy link
Contributor

Narretz commented Feb 13, 2017

We are on node 6 right now :D

@Narretz Narretz closed this as completed Feb 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants