Fix vote account creation with seed #65
Merged
+19
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Mar 12, 2025
There was a problem hiding this comment.
Thanks for the contribution! Noting that this is a remake of anza-xyz/agave#2819 for the sdk repo
This is failing the audit step in CI, which was fixed last week -- can you rebase your branch?
nelsontky
force-pushed
the
fix-vote-account-creation-with-seed
branch
from
4884da4 to
b84c96d
Compare
|
sflr, but just rebased! Appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_account_with_configdid not properly support account creation using a seed, even though it was intended to. The function now correctly checks for the presence of a seed inconfig.with_seedand callscreate_account_with_seedwhen applicable.Closes anza-xyz/agave#2819