Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update apisix_route_v2.md #2175

Merged
merged 2 commits into from
Mar 11, 2024
Merged

docs: Update apisix_route_v2.md #2175

merged 2 commits into from
Mar 11, 2024

Conversation

kworkbee
Copy link

@kworkbee kworkbee commented Mar 6, 2024

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Some properties that CRD defines are missing descriptions and have been added.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

pottekkat
pottekkat requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@pottekkat pottekkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this and opening a PR. I have added some suggestions so that it is clearer and fits with the existing docs.

@kworkbee kworkbee requested a review from pottekkat March 7, 2024 08:02
@Revolyssup Revolyssup merged commit de8ad1c into apache:v1.8.0 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Revolyssup Revolyssup Revolyssup approved these changes

@pottekkat pottekkat pottekkat approved these changes

@bzp2010 bzp2010 Awaiting requested review from bzp2010

@shreemaan-abhishek shreemaan-abhishek Awaiting requested review from shreemaan-abhishek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kworkbee @Revolyssup @pottekkat