Skip to content

chore: replace istanbul with nyc #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

chore: replace istanbul with nyc #459

merged 1 commit into from
Oct 16, 2019
+16 −4

Conversation

erisu
Copy link
Member

@erisu erisu commented Sep 10, 2019 •
edited by raphinesse
Loading

Motivation and Context

  • Remove npm install warnings of a deprecated package.
  • Be consistent with the packages we use in other repos.

Description

  • Remove istanbul package
  • Add nyc package
  • Update .gitignore and .npmignore to exclude the .nyc_output
  • Update npm test to run the coverage instead of jasmine directly which produces the same results + coverage.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu requested a review from dpogue September 10, 2019 06:40
@erisu erisu force-pushed the code-coverage-improvement branch from 1101d85 to 4a72a12 Compare September 10, 2019 06:42
raphinesse
raphinesse approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve both commits, but they should not be squashed

@raphinesse raphinesse force-pushed the code-coverage-improvement branch from 4a72a12 to 1929ac8 Compare October 16, 2019 19:23
@raphinesse raphinesse merged commit 46225e7 into apache:master Oct 16, 2019
@erisu erisu deleted the code-coverage-improvement branch November 1, 2019 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphinesse raphinesse raphinesse approved these changes

@dpogue dpogue Awaiting requested review from dpogue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erisu @raphinesse