fix: cannot call config or create commands #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few exceptions aside, the `cli` function checks if the current command
exists as a property in `cordova-lib`. If not, it throws an error that
the command is unsupported:
Cordova does not know config;
try `cordova help` for a list of all the available commands.
Since the `config` and `create` commands are not handled by
`cordova-lib` anymore and their previous implementations in
`cordova-lib` have recently been removed, we need to make an exceptions
for those commands.
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
==========================================
- Coverage 86.63% 86.58% -0.06%
==========================================
Files 3 3
Lines 247 246 -1
==========================================
- Hits 214 213 -1
Misses 33 33
Continue to review full report at Codecov.
|
erisu
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few exceptions aside, the
clifunction checks if the current command exists as a property incordova-lib. If not, it throws an error that the command is unsupported:Since the
configandcreatecommands are not handled bycordova-libanymore and their previous implementations incordova-libhave recently been removed, we need to make an exceptions for those commands.