-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check the network,Local site be the preferred one #15189
base: 3.3
Are you sure you want to change the base?
Conversation
02840e8
to
605f72c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15189 +/- ##
============================================
+ Coverage 60.76% 60.78% +0.02%
- Complexity 10886 10889 +3
============================================
Files 1885 1885
Lines 86071 86073 +2
Branches 12892 12893 +1
============================================
+ Hits 52298 52323 +25
+ Misses 28326 28307 -19
+ Partials 5447 5443 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
<dubbo:protocol name="dubbo" port="20880" host="192.168.1.100"/> |
You're right, @zrlw. This solves the protocol problem, but there are still some display issues and the need to consider whether there are other related issues. Also, I think we still need to consider the first tip. |
There are many complex network scenarios besides VPN. for example, there might be no other way except to specify ip address and port bound to dubbo provider in docker container. |
How about register all the available ips to registry and let consumer try all the ips? But this might be a bad design:) |
I think so:) |
What is the purpose of the change?
I found an issue: every time I enable the VPN, Dubbo's local address check always picks up the VPN address instead of my machine's actual address. This leads to an incorrect address selection, preventing normal startup.
I found a similar issue reported a long time ago. Here are two ideas I have:
2.Add an IP parameter to specify the preferred local network interface instead of relying on the interface name parameter.
Checklist