Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoconfiguration virtual-thread-pool #15220

Open
wants to merge 4 commits into
base: 3.3
Choose a base branch
from

Conversation

heliang666s
Copy link
Contributor

What is the purpose of the change?

fix #15158

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.77%. Comparing base (3e5216f) to head (5530066).
Report is 17 commits behind head on 3.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15220      +/-   ##
============================================
- Coverage     60.78%   60.77%   -0.01%     
- Complexity    10890    10893       +3     
============================================
  Files          1885     1885              
  Lines         86072    86077       +5     
  Branches      12892    12894       +2     
============================================
- Hits          52319    52317       -2     
- Misses        28306    28315       +9     
+ Partials       5447     5445       -2     
Flag Coverage Δ
integration-tests 33.10% <0.00%> (+0.02%) ⬆️
samples-tests 29.19% <60.00%> (-0.01%) ⬇️
unit-tests 58.90% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Stellar1999
Copy link
Contributor

As far as I know, Virtual Threads is a new feature introduced after JDK 21, and Spring Boot added support for it starting from version 3.2. Should we add this configuration in dubbo-spring-boot-3?

@heliang666s
Copy link
Contributor Author

As far as I know, Virtual Threads is a new feature introduced after JDK 21, and Spring Boot added support for it starting from version 3.2. Should we add this configuration in dubbo-spring-boot-3?

but we don‘t have dubbo-spring-boot-3,only have dubbo-spring-boot-3-autoconfigure,but spring-boot-3-autoconfigure mainly handles aspects related to the Triple protocol, which is not closely related to configuration. Moreover, all configuration is processed in DubboDefaultPropertiesEnvironmentPostProcessor.java. Additionally, I believe that if the user is not using JDK 21 and Spring Boot 3, they wouldn't enable this configuration anyway.@Stellar1999

return defaultProperties;
}

private void setDubboVirtualThreadsProperty(Environment environment, Map<String, Object> defaultProperties) {
String virtualEnabled = environment.getProperty(SPRING_THREAD_POOL_PROPERTY);
if (StringUtils.hasLength(virtualEnabled)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the value here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants