Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-37332] Support any column as chunk key column (postgres, orcale, db2, sqlserver) #3922 #3928

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-37332] Support any column as chunk key column (postgres, orcale, db2, sqlserver) #3922 #3928

wants to merge 1 commit into from

Conversation

SML0127
Copy link
Contributor

@SML0127 SML0127 commented Feb 21, 2025 •
edited
Loading

This close #3922.
MySQL CDC connector supports this feature from flink cdc v3.2
Now, other connectors that support incremental snapshot allow any columns as chunk key column

apache jira: https://issues.apache.org/jira/browse/FLINK-37332
pr for docs: #3924

cc. @gtk96 @leonardBang @lvyanquan

@SML0127 SML0127 force-pushed the feature/support_chunk_key_for_all_column branch from d9fecad to 10df810 Compare February 22, 2025 07:33
@SML0127
Copy link
Contributor Author

SML0127 commented Mar 11, 2025

@gtk96 @leonardBang @lvyanquan PTAL.

@gtk96
Copy link
Contributor

gtk96 commented Mar 12, 2025

@GOODBOY008 @Jiabao-Sun PTAL

lvyanquan
lvyanquan approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@lvyanquan lvyanquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SML0127
Copy link
Contributor Author

SML0127 commented Mar 12, 2025 •
edited
Loading

Hi, @gong
May I ask for your help with this error?

NewlyAddedTableITCase.testNewlyAddedTableForExistsPipelineThriceWithAheadRedoLog:193->
testNewlyAddedTableOneByOne:592->
testNewlyAddedTableOneByOne:733->
OracleSourceTestBase.assertEqualsInAnyOrder:122->
OracleSourceTestBase.assertEqualsInOrder:130 arrays first differed at element [0]; 
expected:<...16874195632735147, C[HINA], BEIJING, BEIJING W...> 
but was:<...16874195632735147, C[hina], BEIJING, BEIJING W...>

@leonardBang
Copy link
Contributor

@SML0127 Could you rebase to latest master branch which has fixed some unstable mysql case? but for oracle failed case, I think we can file an issue to track.

@SML0127 SML0127 force-pushed the feature/support_chunk_key_for_all_column branch from 10df810 to acc4260 Compare March 12, 2025 15:16
@SML0127
Copy link
Contributor Author

SML0127 commented Mar 12, 2025

@leonardBang Rebase completed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvyanquan lvyanquan lvyanquan approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
base mysql-cdc-connector oracle-cdc-connector postgres-cdc-connector reviewed sqlserver-cdc-connector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SML0127 @gtk96 @leonardBang @lvyanquan