-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35299] Respect initial position for new streams #140
Open
antssilva96
wants to merge
14
commits into
apache:main
Choose a base branch
from
antssilva96:FLINK-35299-respect-stream-initial-position-for-new-streams
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1998af6
Initial commit with the change to respect initial position for new st…
7d43563
Add new property to allow reset of individual streams
49f4bc4
add docs
224b9ad
fix missing initialization of set
f4cac88
fix conditions
1b62ab1
Minor update to comment in javadoc
1230ee0
Add more detail to javadoc comment
5284bb3
update TODO
cc56278
Add initial test - not ready yet but to have a point to come back to …
7739ee4
minor refactor to test setup
1d166df
add remaining tests
190941c
Add new test, improve docs
194744e
Apply code style
636f1f2
minor reword to make docs clearer
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if we are able to set different streams with different INITIAL POSITION. Let's say we would add
streamA
,streamB
andstreamC
as new streams, I want to havestreamA
andstreamB
to consume fromLATEST
andstreamC
fromAT_TIMESTAMP
. Is this possible?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not possible before and is still not possible now 😅
Even though it would be possible to do that with minimal changes, I feel like that is another feature request on its own and probably doesn't belong in this one.
The main goal of this change is: allow users to say when INITIAL position should be used regardless of the stored state.