[FLINK-32097][Connectors/Kinesis] Implement support for Kinesis deaggregation #188
+491
−187
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.connector.kinesis.source.reader; | ||
|
|
||
| import org.apache.flink.annotation.Internal; | ||
| import org.apache.flink.connector.kinesis.source.split.KinesisShardSplit; | ||
|
|
||
| import software.amazon.awssdk.services.kinesis.model.Record; | ||
| import software.amazon.kinesis.retrieval.AggregatorUtil; | ||
| import software.amazon.kinesis.retrieval.KinesisClientRecord; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| /** | ||
| * Dataclass to store a batch of Kinesis records with metadata. Used to pass Kinesis records from | ||
| * the SplitReader implementation to the SplitReaderBase. | ||
| * | ||
| * <p>Input records are de-aggregated using KCL 3.x library. It is expected that AWS SDK v2.x | ||
| * messages are converted to KCL 3.x {@link KinesisClientRecord}. | ||
| */ | ||
| @Internal | ||
| public class RecordBatch { | ||
| private final List<KinesisClientRecord> deaggregatedRecords; | ||
| private final long millisBehindLatest; | ||
| private final boolean completed; | ||
|
|
||
| public RecordBatch( | ||
| final List<Record> records, | ||
| final KinesisShardSplit subscribedShard, | ||
| final long millisBehindLatest, | ||
| final boolean completed) { | ||
| this.deaggregatedRecords = deaggregateRecords(records, subscribedShard); | ||
| this.millisBehindLatest = millisBehindLatest; | ||
| this.completed = completed; | ||
| } | ||
|
|
||
| public List<KinesisClientRecord> getDeaggregatedRecords() { | ||
| return deaggregatedRecords; | ||
| } | ||
|
|
||
| public long getMillisBehindLatest() { | ||
| return millisBehindLatest; | ||
| } | ||
|
|
||
| public boolean isCompleted() { | ||
| return completed; | ||
| } | ||
|
|
||
| private List<KinesisClientRecord> deaggregateRecords( | ||
| final List<Record> records, final KinesisShardSplit subscribedShard) { | ||
| final List<KinesisClientRecord> kinesisClientRecords = new ArrayList<>(); | ||
| for (Record record : records) { | ||
| kinesisClientRecords.add(KinesisClientRecord.fromRecord(record)); | ||
| } | ||
|
|
||
| final String startingHashKey = subscribedShard.getStartingHashKey(); | ||
| final String endingHashKey = subscribedShard.getEndingHashKey(); | ||
|
|
||
| return new AggregatorUtil() | ||
| .deaggregate(kinesisClientRecords, startingHashKey, endingHashKey); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.connector.kinesis.source.reader; | ||
|
|
||
| import org.apache.flink.connector.kinesis.source.util.TestUtil; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
| import software.amazon.awssdk.services.kinesis.model.Record; | ||
|
|
||
| import java.util.Collections; | ||
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
| import java.util.stream.Stream; | ||
|
|
||
| import static org.apache.flink.connector.kinesis.source.util.TestUtil.getTestRecord; | ||
| import static org.apache.flink.connector.kinesis.source.util.TestUtil.getTestSplit; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| class RecordBatchTest { | ||
|
|
||
| @Test | ||
| public void testDeaggregateRecordsPassThrough() { | ||
| List<Record> records = | ||
| Stream.of(getTestRecord("data-1"), getTestRecord("data-2"), getTestRecord("data-3")) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| RecordBatch result = new RecordBatch(records, getTestSplit(), 100L, true); | ||
|
|
||
| assertThat(result.getDeaggregatedRecords().size()).isEqualTo(3); | ||
| } | ||
|
|
||
| @Test | ||
| public void testDeaggregateRecordsWithAggregatedRecords() { | ||
| List<Record> records = | ||
| Stream.of(getTestRecord("data-1"), getTestRecord("data-2"), getTestRecord("data-3")) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| Record aggregatedRecord = TestUtil.createAggregatedRecord(records); | ||
|
|
||
| RecordBatch result = | ||
| new RecordBatch( | ||
| Collections.singletonList(aggregatedRecord), getTestSplit(), 100L, true); | ||
|
|
||
| assertThat(result.getDeaggregatedRecords().size()).isEqualTo(3); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetMillisBehindLatest() { | ||
| RecordBatch result = | ||
| new RecordBatch( | ||
| Collections.singletonList(getTestRecord("data-1")), | ||
| getTestSplit(), | ||
| 100L, | ||
| true); | ||
|
|
||
| assertThat(result.getMillisBehindLatest()).isEqualTo(100L); | ||
| } | ||
|
|
||
| @Test | ||
| public void testIsCompleted() { | ||
| RecordBatch result = | ||
| new RecordBatch( | ||
| Collections.singletonList(getTestRecord("data-1")), | ||
| getTestSplit(), | ||
| 100L, | ||
| true); | ||
|
|
||
| assertThat(result.isCompleted()).isTrue(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has Apache 2.0 licence, all good so
https://github.com/awslabs/kinesis-aggregation