[FLINK-20628] Port RabbitMQ Connector using unified Source #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
RocMarshal
commented
Sep 12, 2023
| * <p>Note that the higher the consistency guarantee gets, fewer messages can be processed by the | ||
| * system. At-least-once and exactly-once should only be used if necessary. | ||
| */ | ||
| public enum ConsistencyMode { |
There was a problem hiding this comment.
Should we use DeliveryGuarantee to replace the ConsistencyMode ?
|
@RocMarshal Without actually seeing a passing CI, it doesn't make much sense to review this one... |
|
The new sink #29 |
Got it. |
RabbitMQ Connector using the new Source API https://issues.apache.org/jira/browse/FLINK-20628 Co-authored-by: Yannik Schroeder <[email protected]> Co-authored-by: Jan Westphal <[email protected]> Co-authored-by: Pascal Schulze <[email protected]>
RocMarshal
changed the title
|
@vahmed-hamdy will take over it(With discussion offline). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related pr #1