Fork beeline module from Apache Hive 3.1.3 #6109

pan3793 · 2024-02-28T04:34:06Z

🔍 Description

Issue References 🔗

This is the first step of #6146, to gain a clear commit history, this PR just simply copied the hive-beeline module from Apache Hive 3.1.3, with minimal change to pass the tests and manually test basic functionalities, following PRs are going to remove other Hive deps gradually.

Describe Your Solution 🔧

Copy source code and test case from Apache Hive 3.1.3
Drop org.apache.hive:hive-beeline:3.1.3
Backport HIVE-21584 to support JDK 9+
Drop HiveCli, HiveSchemaTool and BeelineInPlaceUpdateStream, and the corresponding test cases
Temporary ignore(will fix later) TestClientCommandHookFactory#testConnectHook because of error NoClassDefFound org/apache/curator/RetryPolicy
Tune testing code to pass UT

Types of changes 🔖

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Minimal changes to pass the unit tests.

Checklist 📝

This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

pan3793 · 2024-02-28T05:35:58Z

Before completing the work, I'd like to collect feedback from the community first.

yaooqinn · 2024-02-28T06:15:25Z

I'm not a fan of fork instead of upstream first. I have no comments. Leave it to others to decide.

pan3793 · 2024-03-07T03:31:42Z

The change is almost done, I manually tested some cases locally, and everything went well.

This is the last part to cut Hive deps out from Kyuubi server and client modules.

I'm going to split it to gain a clear changelog history.

codecov-commenter · 2024-03-10T19:01:28Z

Codecov Report

Attention: Patch coverage is 34.03951% with 2304 lines in your changes are missing coverage. Please review.

Project coverage is 58.69%. Comparing base (9c18a7e) to head (885f9fe).
Report is 1 commits behind head on master.

Files	Patch %	Lines
...rc/main/java/org/apache/hive/beeline/Commands.java	9.15%	797 Missing and 27 partials ⚠️
...src/main/java/org/apache/hive/beeline/BeeLine.java	43.45%	521 Missing and 62 partials ⚠️
...main/java/org/apache/hive/beeline/BeeLineOpts.java	46.35%	135 Missing and 12 partials ⚠️
...va/org/apache/hive/beeline/DatabaseConnection.java	16.55%	118 Missing and 8 partials ⚠️
.../beeline/hs2connection/HS2ConnectionFileUtils.java	39.68%	71 Missing and 5 partials ⚠️
...hs2connection/HiveSiteHS2ConnectionFileParser.java	0.00%	74 Missing ⚠️
.../hive/beeline/hs2connection/BeelineSiteParser.java	19.67%	45 Missing and 4 partials ⚠️
...ache/hive/beeline/SeparatedValuesOutputFormat.java	10.00%	45 Missing ⚠️
...c/main/java/org/apache/hive/beeline/Reflector.java	34.48%	17 Missing and 21 partials ⚠️
...ain/java/org/apache/hive/beeline/SQLCompleter.java	0.00%	38 Missing ⚠️
... and 26 more

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #6109      +/-   ##
============================================
- Coverage     61.08%   58.69%   -2.40%     
  Complexity       24       24              
============================================
  Files           625      663      +38     
  Lines         37219    40712    +3493     
  Branches       5029     5602     +573     
============================================
+ Hits          22735    23895    +1160     
- Misses        12040    14187    +2147     
- Partials       2444     2630     +186

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ulysses-you · 2024-03-11T02:47:41Z

why fork beeline module can resolve CVE, does those transitive dependencies go away ?

pan3793 · 2024-03-11T02:50:18Z

why fork beeline module can resolve CVE, does those transitive dependencies go away ?

Fork and do minor changes can cut out all Hive's vulnerable deps. To gain a clear git history, those minor changes are planed in follow-up PRs.

pan3793 · 2024-03-11T02:51:21Z

@ulysses-you the whole proposal is listed under #6146

cfmcgrady · 2024-03-11T03:01:54Z

Fork and do minor changes can cut out all Hive's vulnerable deps.

+1

ulysses-you

we can go back to upstream once Hive community become active on beeline module

pan3793 · 2024-03-11T03:26:51Z

Thanks, merged to master

# 🔍 Description ## Issue References 🔗 This is the first step of apache#6146, to gain a clear commit history, this PR just simply copied the `hive-beeline` module from Apache Hive 3.1.3, with minimal change to pass the tests and manually test basic functionalities, following PRs are going to remove other Hive deps gradually. ## Describe Your Solution 🔧 - Copy source code and test case from Apache Hive 3.1.3 - Drop `org.apache.hive:hive-beeline:3.1.3` - Backport HIVE-21584 to support JDK 9+ - Drop `HiveCli`, `HiveSchemaTool` and `BeelineInPlaceUpdateStream`, and the corresponding test cases - Temporary ignore(will fix later) `TestClientCommandHookFactory#testConnectHook` because of error `NoClassDefFound org/apache/curator/RetryPolicy` - Tune testing code to pass UT ## Types of changes :bookmark: - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Minimal changes to pass the unit tests. --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6109 from pan3793/fork-beeline. Closes apache#6109 885f9fe [Cheng Pan] NOTICE a2efa1c [Cheng Pan] fix 5bb1cc9 [Cheng Pan] Copy from Apache Hive 3.1.3 Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>

github-actions bot added module:hive module:ctl labels Feb 28, 2024

pan3793 requested review from turboFei and yaooqinn February 28, 2024 05:58

pan3793 force-pushed the fork-beeline branch from bfc05db to 898a24e Compare March 6, 2024 14:24

github-actions bot added the kind:build label Mar 6, 2024

pan3793 force-pushed the fork-beeline branch 2 times, most recently from e9161d7 to 87f31af Compare March 7, 2024 11:40

pan3793 mentioned this pull request Mar 8, 2024

[Umbrella] Fork beeline module and cut out Hive deps #6146

Closed

4 tasks

pan3793 added 2 commits March 11, 2024 02:59

Copy from Apache Hive 3.1.3

5bb1cc9

fix

a2efa1c

pan3793 force-pushed the fork-beeline branch from 87f31af to a2efa1c Compare March 10, 2024 19:01

pan3793 marked this pull request as ready for review March 10, 2024 19:07

NOTICE

885f9fe

github-actions bot added the kind:infra license, community building, project builds, asf infra related, etc. label Mar 10, 2024

pan3793 requested a review from ulysses-you March 11, 2024 02:16

pan3793 self-assigned this Mar 11, 2024

pan3793 added this to the v1.9.0 milestone Mar 11, 2024

cfmcgrady approved these changes Mar 11, 2024

View reviewed changes

ulysses-you approved these changes Mar 11, 2024

View reviewed changes

pan3793 closed this in 64058a0 Mar 11, 2024

turboFei approved these changes Mar 11, 2024

View reviewed changes

pan3793 mentioned this pull request Apr 7, 2024

[TASK][EASY] Kyuubi BeeLine supports JSON output format #6266

Closed

3 tasks

pan3793 deleted the fork-beeline branch June 6, 2024 18:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fork beeline module from Apache Hive 3.1.3 #6109

Fork beeline module from Apache Hive 3.1.3 #6109

pan3793 commented Feb 28, 2024 •

edited

Loading

pan3793 commented Feb 28, 2024

yaooqinn commented Feb 28, 2024

pan3793 commented Mar 7, 2024

codecov-commenter commented Mar 10, 2024 •

edited

Loading

ulysses-you commented Mar 11, 2024

pan3793 commented Mar 11, 2024

pan3793 commented Mar 11, 2024

cfmcgrady commented Mar 11, 2024

ulysses-you left a comment

pan3793 commented Mar 11, 2024

Fork beeline module from Apache Hive 3.1.3 #6109

Fork beeline module from Apache Hive 3.1.3 #6109

Conversation

pan3793 commented Feb 28, 2024 • edited Loading

🔍 Description

Issue References 🔗

Describe Your Solution 🔧

Types of changes 🔖

Test Plan 🧪

Checklist 📝

pan3793 commented Feb 28, 2024

yaooqinn commented Feb 28, 2024

pan3793 commented Mar 7, 2024

codecov-commenter commented Mar 10, 2024 • edited Loading

Codecov Report

ulysses-you commented Mar 11, 2024

pan3793 commented Mar 11, 2024

pan3793 commented Mar 11, 2024

cfmcgrady commented Mar 11, 2024

ulysses-you left a comment

Choose a reason for hiding this comment

pan3793 commented Mar 11, 2024

pan3793 commented Feb 28, 2024 •

edited

Loading

codecov-commenter commented Mar 10, 2024 •

edited

Loading