Speedup slice calculation in IndexSearcher #14343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's in the title, some obvious speedups. This is fairly expensive logic for Elasticsearch when run over a larger number of shards. No need for streams, creating comparator instances and so much copying here.
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
msfroh
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Nice cleanup! Cutting down on the number of unnecessary allocations is nice.
I wonder if it makes sense to require that the input to the LeafSlice constructor is already sorted? In general, the way that they get created (even with segment partitions) could be sorted externally. That said, for the common existing case where each slice has one partition, the sort will fast-return anyway.
|
Thanks Michael! |
github-project-automation
bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
original-brownbear
added a commit
that referenced
this pull request
Mar 12, 2025
It's in the title, some obvious speedups. This is fairly expensive logic for Elasticsearch when run over a larger number of shards. No need for streams, creating comparator instances and so much copying here.
hanbj
pushed a commit
to hanbj/lucene
that referenced
this pull request
Mar 12, 2025
It's in the title, some obvious speedups. This is fairly expensive logic for Elasticsearch when run over a larger number of shards. No need for streams, creating comparator instances and so much copying here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's in the title, some obvious speedups. This is fairly expensive logic for Elasticsearch when run over a larger number of shards. No need for streams, creating comparator instances and so much copying here.