HDDS-12583. Skip Fields in protobuf while deserializing protobuf #8068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I00f9f5d6b39e2d3e8a401b5ff55b7d35691f24ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I00f9f5d6b39e2d3e8a401b5ff55b7d35691f24ab
What changes were proposed in this pull request?
Currently while deserializing really bulky KeyInfo/DirectoryInfo a lot of time is spent on just deserializing the proto and creating a java pojo and some iterations of these keys don't need bulky fields. We can actually skip deserializing these bulky optional fields while deserializing the proto itself.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12583
How was this patch tested?
Adding unit tests wip