HDDS-12590. Used db name as the threadNamePrefix. #8076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandakumar131
approved these changes
Mar 14, 2025
sadanand48
approved these changes
Mar 14, 2025
adoroszlai
approved these changes
Mar 14, 2025
There was a problem hiding this comment.
Thanks @szetszwo for the patch, nice improvement.
In general, prefix is set to some ID of the service (datanode/OM/SCM/Recon), for easier understanding of MiniOzoneCluster logs (HDDS-8719), where multiple instances can be emitting similar messages.
Thanks for spotting that it is never set for DBStore, this is a bug. Looking at how deep DBStoreBuilder is in various call hierarchies, adding a real prefix seems difficult. Also, it is only used in cache cleanup, which only has one log message, at debug level.
|
@nandakumar131 , @sadanand48 , @adoroszlai , thanks a lot for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The actual value of threadNamePrefix parameter in the db/table related classes is always an empty string. Let's simply use the db name as threadNamePrefix and remove the parameter.
What is the link to the Apache JIRA
HDDS-12590
How was this patch tested?
By existing tests