HDDS-12600. Acls should be lazily loaded only when the acls are updated or serialized back OmKeyInfo/OmDirectoryInfo #8077
+54
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed or serialized back OmKeyInfo/OmDirectoryInfo Change-Id: I632bde0bce5fc0014f5a7e4eca96c6aa8a9f5f99
Change-Id: I848ad170273e855c98c9823d6e0659d5bef69b27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently on Deserialization of a bulky OmKeyInfo & OmDirectoryInfo takes a really long time if the key has too many Acls and a good amount of time is spent in the following function while converting a proto KeyInfo to Java OmKeyInfo
ozone/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneAclUtil.java
Line 194 in 2f3150a
This patch proposes to lazily load the acl info if the object is going to be only read and in most of the flows these ACLs are never used and we end up wasting CPU in deserializing the entire ACL info.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12600
How was this patch tested?
Existing unit tests & performance benchmarking in progress.