HDDS-12486. Warmup KMS encrypted keys when OM starts #8081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojochuang
reviewed
Mar 17, 2025
| @@ -622,4 +622,16 @@ private OMConfigKeys() { | |||
| public static final String OZONE_OM_MAX_BUCKET = | |||
| "ozone.om.max.buckets"; | |||
| public static final int OZONE_OM_MAX_BUCKET_DEFAULT = 100000; | |||
|
|
|||
| public static final String OZONE_OM_EDEKCACHELOADER_INITIAL_DELAY_MS_KEY = "ozone.om.edekcacheloader.initial.delay.ms"; | |||
There was a problem hiding this comment.
Let's add these configuration properties into ozone-default.xml?
| @@ -644,6 +655,7 @@ private OzoneManager(OzoneConfiguration conf, StartupOption startupOption) | |||
| kmsProvider = null; | |||
| LOG.error("Fail to create Key Provider"); | |||
| } | |||
| initializeEdekCache(conf); | |||
There was a problem hiding this comment.
it should only run if it's a leader node.
| } | ||
|
|
||
| public void warmUpEdekCache(final ExecutorService executor, final int delay, final int interval, int maxRetries) { | ||
| List<String> keys = new ArrayList<>(); |
There was a problem hiding this comment.
Multiple buckets could use the same encryption key. Doing so could warm up the same encryption key multiple times, causing unnecessary delays. Let's use HashSet to eliminate duplicates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Creating an Ozone file in encrypted buckets requires requesting an encrypted key from KMS, which delays file creation and could cause unwanted failures. This PR helps load the EDEKs in a cache when OM starts up so that we don't have to reach out to KMS to get the EDEK while creating an encrypted file.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12486
How was this patch tested?
Tested Manually.