Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-12303. Move ozone.om.user.max.volume into OmConfig #8082

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

octachoron
Copy link
Contributor

What changes were proposed in this pull request?

To take advantage of the type safety and reduced boilerplate offered by configuration objects (HDDS-1466), this PR moves the definition of the ozone.om.user.max.volume parameter into OmConfig, and updates its single usage accordingly.

In addition to the steps described on HDDS-12303, the following changes are also made:

  • Removing the definition from ozone-default.xml, as it is now generated from the annotations.
  • Removing the configuration key and default from OMConfigKeys, as there are no usages left.
  • Removing the now unused imports from OzoneManager.
  • Adding the full configuration key to OmConfig to allow keeping the validation unchanged in a straightforward way.
  • Including the new member in copy() and setFrom(), with the rationale that if they are offered as such, they should be complete. (Even though they seem to be intended for use in specific tests that make no changes to the parameter.)
  • Adding a setter for the new member to allow updating TestOmConfig.testSetFrom().
  • Updating the assertion corresponding to said update.
  • Adding a unit test to cover the validation moved to OmConfig.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12303

How was this patch tested?

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @octachoron for the patch.

@adoroszlai adoroszlai merged commit 5b7f96c into apache:master Mar 14, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants