Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-12614. Configurable java version in flaky-test-check with default to 21 #8097

Merged
merged 2 commits into from
Mar 16, 2025

Conversation

peterxcli
Copy link
Contributor

@peterxcli peterxcli commented Mar 16, 2025

What changes were proposed in this pull request?

Just noticed that flaky-test-check ci workflow still use java 8 to run.
Currently, main ci test run with java 21. We should align to it.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12614

How was this patch tested?

CI:
https://github.com/peterxcli/ozone/actions/runs/13883456997

trigger flaky-test-check:

@peterxcli
Copy link
Contributor Author

cc @adoroszlai, please take a look. Thanks.

@peterxcli peterxcli changed the title HDDS-12614. Use java 21 in flaky-test-check HDDS-12614. Configurable java version in flaky-test-check with default to 21 Mar 16, 2025
@peterxcli peterxcli marked this pull request as draft March 16, 2025 12:24
@peterxcli
Copy link
Contributor Author

peterxcli commented Mar 16, 2025

Sorry, I think I made a mistake. let me fix it.

@peterxcli peterxcli force-pushed the flaky-test-check-java21 branch from 37391ec to c3bae69 Compare March 16, 2025 12:29
@peterxcli peterxcli force-pushed the flaky-test-check-java21 branch from c3bae69 to e5ac5ed Compare March 16, 2025 12:34
@peterxcli peterxcli marked this pull request as ready for review March 16, 2025 12:39
@peterxcli
Copy link
Contributor Author

ok, fixed.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peterxcli for the patch, LGTM.

@adoroszlai adoroszlai merged commit 28520a7 into apache:master Mar 16, 2025
16 checks passed
@peterxcli
Copy link
Contributor Author

Thanks @adoroszlai for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants