Skip to content

Commit 40aca1b

Browse files
authored
Fix sonar issue on StandaloneMetaDataManagerPersistService (#34989)
1 parent f5b86a0 commit 40aca1b

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

mode/type/standalone/core/src/main/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistService.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -195,14 +195,13 @@ private void afterStorageUnitsAltered(final String databaseName, final MetaDataC
195195
@Override
196196
public void unregisterStorageUnits(final ShardingSphereDatabase database, final Collection<String> toBeDroppedStorageUnitNames) {
197197
for (String each : getToBeDroppedResourceNames(database.getName(), toBeDroppedStorageUnitNames)) {
198-
MetaDataContexts originalMetaDataContexts = new MetaDataContexts(metaDataContextManager.getMetaDataContexts().getMetaData(), metaDataContextManager.getMetaDataContexts().getStatistics());
199198
metaDataPersistFacade.getDataSourceUnitService().delete(database.getName(), each);
200-
afterStorageUnitsUnregistered(database.getName(), originalMetaDataContexts, each);
199+
afterStorageUnitsUnregistered(database.getName(), each);
201200
}
202201
clearServiceCache();
203202
}
204203

205-
private void afterStorageUnitsUnregistered(final String databaseName, final MetaDataContexts originalMetaDataContexts, final String storageUnitName) {
204+
private void afterStorageUnitsUnregistered(final String databaseName, final String storageUnitName) {
206205
metaDataContextManager.getStorageUnitManager().unregister(databaseName, storageUnitName);
207206
MetaDataContexts reloadMetaDataContexts = metaDataContextManager.getMetaDataContexts();
208207
ShardingSphereDatabase database = reloadMetaDataContexts.getMetaData().getDatabase(databaseName);

0 commit comments

Comments
 (0)