Skip to content

[SPARK-45994][PYTHON][3.4] Change description-file to description_file #50374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bjornjorgensen
Copy link
Contributor

What changes were proposed in this pull request?

Change description-file to description_file

Why are the changes needed?

./dev/make-distribution.sh --name custom-spark --pip -Pkubernetes > output.txt 2>&1
in the file there is this

+ echo 'Building python distribution package'
Building python distribution package
+ pushd /home/bjorn/spark/python
+ rm -rf pyspark.egg-info
+ python3 setup.py sdist
/usr/lib/python3.11/site-packages/setuptools/dist.py:745: SetuptoolsDeprecationWarning: Invalid dash-separated options
!!

        ********************************************************************************
        Usage of dash-separated 'description-file' will not be supported in future
        versions. Please use the underscore name 'description_file' instead.

        This deprecation is overdue, please update your project and remove deprecated
        calls to avoid build errors in the future.

        See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
        ********************************************************************************

!!
  opt = self.warn_dash_deprecation(opt, section)
running sdist
running egg_info

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA

Was this patch authored or co-authored using generative AI tooling?

No.

@bjornjorgensen bjornjorgensen changed the title [3.4][SPARK-45994][PYTHON] Change description-file to description_file [SPARK-45994][PYTHON][3.4] Change description-file to description_file Mar 24, 2025
@drsnyder
Copy link

Should that option be removed entirely? It doesn't appear to be supported (doc, related).

@bjornjorgensen
Copy link
Contributor Author

well, it is what those that are making the program recommend. And there are many other that get the same message like google/sentencepiece#740

@bjornjorgensen
Copy link
Contributor Author

4) Spark 3.4.4: Released on October 27, 2024. This will be the final maintenance release for the 3.4 series.

so I will close this on.

@bjornjorgensen
Copy link
Contributor Author

SO Does description-file in setup.cfg, section "metadata" have any effect? But I don't wanna change something with this only make it build. I think there can be another PR where we change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants