Skip to content

[STORM-3388] Followup fix: HdfsOciResourcesLocalizer should create necessary nonexistent parent directoires #3407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

Ethanlm
Copy link
Contributor

@Ethanlm Ethanlm commented Aug 11, 2021

What is the purpose of the change

When deployed to a new node, <parent-path>/supervisor/oci-resources/config/ might not exist, so mkdir("<parent-path>/supervisor/oci-resources/config/working") will fail:

2021-08-09 19:17:34.047 o.a.s.d.s.Slot SLOT_6702 [ERROR] Failed launching container
java.io.IOException: Couldn't create the directory: /home/y/var/storm/supervisor/oci-resources/config/working
        at org.apache.storm.container.oci.HdfsOciResourcesLocalizer.localize(HdfsOciResourcesLocalizer.java:94)

We just need to make sure parent directories are always created by using mkdirs

How was the change tested

Tested to a newly deployed node and applied the path, submitted a word-count topology and verified that the supervisor was able to create the directories and run the topology properly.

@Ethanlm Ethanlm merged commit 16ca56e into apache:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants