Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-1347. Fix the syntax error reported in sonarcloud. #1018

Closed
wants to merge 1 commit into from

Conversation

hhcs9527
Copy link
Contributor

What is this PR for?

Fix the syntax error reported in sonarcloud.

What type of PR is it?

Bug Fix

Todos

  • - Task

What is the Jira issue?

SUBMARINE-1347

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #1018 (900a375) into master (179ce61) will not change coverage.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##             master    #1018   +/-   ##
=========================================
  Coverage     25.48%   25.48%           
  Complexity     1079     1079           
=========================================
  Files           358      358           
  Lines         29089    29089           
  Branches       3479     3479           
=========================================
  Hits           7412     7412           
+ Misses        21463    21461    -2     
- Partials        214      216    +2     
Flag Coverage Δ
python-integration 59.59% <ø> (ø)
python-unit 52.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../submarine/server/manager/ModelVersionManager.java 45.56% <ø> (ø)
...bmarine/server/manager/RegisteredModelManager.java 61.19% <ø> (ø)
...marine/server/submitter/k8s/model/mljob/MLJob.java 85.58% <0.00%> (ø)
...submitter/k8s/model/xgboostjob/XGBoostJobList.java 0.00% <0.00%> (ø)
...he/submarine/server/websocket/WebSocketServer.java 52.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hhcs9527
Copy link
Contributor Author

@cdmikechen please take a look at the pr, thanks.

@asfgit asfgit closed this in f492e42 Nov 20, 2022
@cdmikechen
Copy link
Contributor

@pingsutw @hhcs9527
I think there is still a problem with this change in XGBoostJobList, as there is only a get method, so we need to initialize the relevant variables, otherwise there will be a NPE.
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants