Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
PyHive added support for Python 3.11 and SQLAlchemy 2.0 recently.
pure-sasl library is installed in all PY versions since it is a dependency of thrift-sasl, a dependency of PyHive.
PY < 3.11: sasl library will be installed and used as PyHive's code gives it first preference.
PY >= 3.11 Only pure-sasl library will be installed and used.
test-postgres-hive
CI test in this repo will always pure-sasl because PY 11 test cases fail if sasl is installed.Note:
'pyhive[hive]'
extras uses sasl that doesn't support Python 3.11, See cloudera/python-sasl#30. Hence PyHive also supports pure-sasl via additional extras'pyhive[hive_pure_sasl]'
which support Python 3.11 along with all previous Python versions.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
PY 3.11: https://github.com/apache/superset/actions/runs/5945658123/job/16125068727?pr=25030
PY 3.10: https://github.com/apache/superset/actions/runs/5945651721/job/16125052276?pr=25030
PY 3.9: https://github.com/apache/superset/actions/runs/5945685670/job/16125136349?pr=25030
cc: @EugeneTorap @bkyryliuk
ADDITIONAL INFORMATION