Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppcheck - records. Fix few warnings, nothing major. #12066

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

cppcheck - records. Fix few warnings, nothing major. #12066

wants to merge 2 commits into from

Conversation

brbzull0
Copy link
Contributor

@brbzull0 brbzull0 commented Mar 3, 2025

  • No logic change, re-arrange some function signature and code location.
  • Make some functions signatures more meanful, removing const from a function that is supposed to modify the object.

@brbzull0 brbzull0 added this to the 10.1.0 milestone Mar 3, 2025
@brbzull0 brbzull0 self-assigned this Mar 3, 2025
@brbzull0
Copy link
Contributor Author

brbzull0 commented Mar 3, 2025

[approve ci autest 1]

@brbzull0
Copy link
Contributor Author

brbzull0 commented Mar 3, 2025

[approve ci autest 0]

@bryancall
Copy link
Contributor

[approve ci autest 1]

@bryancall bryancall requested a review from cmcfarlen March 3, 2025 23:09
JosiahWI
JosiahWI previously requested changes Mar 4, 2025
View reviewed changes
@cmcfarlen cmcfarlen requested a review from JosiahWI March 6, 2025 15:21
@JosiahWI JosiahWI dismissed their stale review March 6, 2025 16:07

Changes were applied.

@cmcfarlen cmcfarlen modified the milestones: 10.1.0, 10.2.0 Mar 10, 2025
@brbzull0
Copy link
Contributor Author

ping @JosiahWI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmcfarlen cmcfarlen Awaiting requested review from cmcfarlen

@JosiahWI JosiahWI Awaiting requested review from JosiahWI

At least 1 approving review is required to merge this pull request.

Assignees

@brbzull0 brbzull0

Labels
Cleanup
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@brbzull0 @bryancall @JosiahWI @cmcfarlen