-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUST][FRONTEND] Add rust frontend v0.1 #2292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work so far! a few more comments for your perusal :)
I'm looking forward to having this merged!
In what context is this bug occurring? The most likely cause is that LD_LIBRARY_PATH simply becomes unset. |
@nhynes Please checkout task_rust.sh. |
What happens if you also export |
@nhynes Already exported in tests/scripts/task_rust.sh and I didn't change that. |
I will take a pass over this later today. |
@nhynes pinging for the updated PR! |
re-reviewing now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! this is the last round of changes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled the branch and made some changes w.r.t. returning references instead of sprinkling in to_owned
s
We're going to need to work on error messages
isn't a very helpful output of |
@nhynes The jenkins image has been updated. Please submit an empty commit to retrigger the CI |
Sorry, I have to revert the image due to a short outrage to recover ANTLR, will send in update |
Overview
I'm delighted to submit this PR which adds Rust runtime frontend support as part of RFC 1601.
You can see the dev here. Here's a summary
tvm_frontend
bindings and idiomatic Rust API.common
crate refactoringTVMArgValue
andTVMRetValue
and unifying FFI across runtime and frontend.@nhynes @tqchen @jroesch
resolves #2306