-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[resource-scraper] introduce utility integration #2304
Conversation
error:
|
3fdd943
to
01ef9e1
Compare
mypy cast commit details: python/mypy#1020, https://mypy.readthedocs.io/en/stable/common_issues.html#complex-type-tests |
QONTRACT_INTEGRATION = "resource-scraper" | ||
|
||
|
||
def run(dry_run, namespace_name, resource_kind, vault_output_path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this Maor! Can you also add support for filtering on labels? The way we were scraping the secrets was to filter on the label:
oc get secret ... -l app=openshift-sre-token-scraper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contributions are welcome? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing with Dustin we are going to merge as-is, and Dustin will contribute a patch to add filtering on a later MR.
0d2edde
to
fff3d5f
Compare
0578924
to
8c5a813
Compare
this is a utility integration that collects resources from specific namespaces of clusters and stores them in vault.
this utility can be used for different purposes, such as disaster recovery.
the current use case is https://issues.redhat.com/browse/OSD-10326