chore: tune error messages for setHiddenApiPolicy #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ignoring this error won't solve their problems, but rather postpone them. We need to invoke hidden APis anyway, so it would make more sense to just provide such customers with instructions on where to disable such checks (or warn them regarding possible consequences if they would still prefer to ignore the error) |
|
basically agree. hm, then what about something this |
KazuCocoa
changed the title
|
@KazuCocoa Could you please rebase the PR? |
KazuCocoa
force-pushed
the
default-true
branch
from
7ee53cd to
0a4f63e
Compare
|
This pr changed to based on the current master with a force push right now |
mykola-mokhnach
approved these changes
Oct 14, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 14, 2023
## [2.31.1](v2.31.0...v2.31.1) (2023-10-14) ### Miscellaneous Chores * add error log for this.adb.setHiddenApiPolicy error ([#656](#656)) ([5c076c5](5c076c5))
|
🎉 This PR is included in version 2.31.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tune the error message to give more hints for users