Introduces Bytes class
#1019
Introduces Bytes class
#1019
Conversation
This introduces a new `Bytes` standard library class, for working with binary data.
| @Override | ||
| public void visitBytes(VmBytes value) { | ||
| throw new VmExceptionBuilder() | ||
| .evalError("cannotRenderTypeAddConverter", "DataSize", "Protobuf") |
| ["sha256"] { | ||
| Bytes("AQIDBA==").sha256 | ||
| Bytes("").sha256 | ||
| } |
There was a problem hiding this comment.
| } | |
| } | |
| ["sha256Int"] { | |
| Bytes("AQIDBA==").sha256Int | |
| Bytes("").sha256Int | |
| } |
We've added this to the Bytes class. We should add coverage for it.
There was a problem hiding this comment.
We'll probably want some tests for encodeToStringWithCharset("UTF-8") and encodeToStringWithCharset("ISO-8859-1")
| Bytes(List()) == Bytes("") | ||
| Bytes(List(1, 2, 3, 4)) == Bytes("AQIDBA==") | ||
| Bytes(List(1, 2)) != Bytes(List(1, 2, 3, 4)) | ||
| } |
There was a problem hiding this comment.
| } | |
| } | |
| ["length"] { | |
| Bytes(List()).length == 0 | |
| Bytes(List(1, 2, 3, 4)).length == 4 | |
| Bytes("AQIDBA==").length == 4 | |
| } |
There was a problem hiding this comment.
Is it worth also demonstrating that subscripting works?
There was a problem hiding this comment.
It actually doesn't work with bytes
There was a problem hiding this comment.
The following appears to work for me:
# Input
["subscript"] {
Bytes(List(1, 2, 3, 4))[0] == 1
Bytes(List(1, 2, 3, 4))[3] == 4
}
# Output
["subscript"] {
true
true
}There was a problem hiding this comment.
In addition to equality, should we also support comparison operations on a sequence of Byte objects? It is sometimes helpful to lexicographically sort bytes. Java has Byte.compare for this.
There was a problem hiding this comment.
Ah; that wasn't intentional; that shouldn't work.
If you want to compare individual bytes, you can get them off of its value. Bytes is just a wrapper, and not meant to provide things like subscript.
But, if you disagree with this decision, feel free to chime in here: https://github.com/apple/pkl-evolution/pull/14/files#r1984168905
| "".isBase64 | ||
| "AQIDBA==".isBase64 | ||
| !"hello there".isBase64 | ||
| } |
There was a problem hiding this comment.
| } | |
| } | |
| ["toBytesWithCharset"] { | |
| "Hello".toBytesWithCharset("UTF-8").length == 5 | |
| "Hello".toBytesWithCharset("UTF-16").length > 5 | |
| } |
There was a problem hiding this comment.
Love the enthusiasm, but FYI: this is just a draft PR! It's not quite ready for review yet.
| } catch (UnsupportedEncodingException e) { | ||
| throw PklBugException.unreachableCode(); | ||
| } |
There was a problem hiding this comment.
Should we have a more specific exception than just unreachableCode here? We're handed an UnsupportedEncodingException.
There was a problem hiding this comment.
This is an impossible condition; all JVM distributions support UTF-8, UTF-16 and ISO-8859-1
This introduces a new
Bytesstandard library class, for working with binary data.Follows SPICE-0013