Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement underestimatedCount for Product2Sequence #255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement underestimatedCount for Product2Sequence #255

wants to merge 1 commit into from
+16 −0

Conversation

CTMacUser
Copy link
Contributor

Add corresponding tests, one for an overflowed count, and one producing a proper count.

Saw this low-hanging fruit while planning other changes. No need for incomplete implementations if they can be realized within reasonable computational time.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@CTMacUser
Implement underestimatedCount for Product2Sequence
64adba6 
Add corresponding tests, one for an overflowed count, and one producing a proper count.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naveen-C-Ramachandrappa Naveen-C-Ramachandrappa Naveen-C-Ramachandrappa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CTMacUser @Naveen-C-Ramachandrappa