Adjacent Pairs #111
Merged
Adjacent Pairs #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phausler
approved these changes
Mar 26, 2022
kperryua
approved these changes
Mar 29, 2022
parkera
approved these changes
Mar 29, 2022
|
@parkera I think I feel like since this is a pretty straightforward implementation, a well written transliteration from swift-algorithms, has documentation and 100% coverage from tests, to me it reaches the bar for being included in the roadmap to 1.0. |
|
That's fine with me too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to swift-algorithms package introduced
adjacentPairs(), it's equally relevant in the async/await world.I took inspiration from their implementation and updated the relevant documentation.