ci(deps): fix ineffassign and bodyclose in ".*_test.go$" #6777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
changed the title
mmorel-35
changed the title
knqyf263
reviewed
May 27, 2024
| } | ||
|
|
||
| require.NoError(t, err) |
There was a problem hiding this comment.
This looks better to me. Is there any advantage to your change?
There was a problem hiding this comment.
The original code is more simple than the new one but the two enabled linters seems to raise issues with that organisation.
The new one duplicate the code and allows to enable the linters for whole test files.
It could worth creating an issue in golangci-lint, bodyclose or ineffassign if you believe the linters are flaky ? Or maybe embed the if else logic in a dedicated method that might be able to trick the linters
There was a problem hiding this comment.
OK, if it's annoying, we'll disable it later.
knqyf263
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes ineffassign and bodyclose issues in ".*_test.go$"