Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: disable arangolocalstorage crds when enableCRDManagement is false #1005

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wyattwalter
Copy link

As a user of the operator, when I set operator.enableCRDManagement to false, I expected that the helm chart will not try to manage CRDs. However, if I set operator.features.storage to true, that enables CRD for that specific operator. This is causing conflicts for me because CRDs are defined cluster-wide, but I want to have the operator deployed into multiple namespaces.

This changes the behavior to only install the CRDs for the storage operator when both operator.features.storage is true and operator.enableCRDManagement is true.

I do not see a test suite for the Helm charts in this repo, but feel free to point me at one if there is. I checked it locally with:

$ helm template . --set operator.features.storage=true | grep arangolocalstorages.storage.arangodb.com
    name: arangolocalstorages.storage.arangodb.com
$ helm template . --set operator.enableCRDManagement=false --set operator.features.storage=true | grep arangolocalstorages.storage.arangodb.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants