Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various TLS & Sync related fixes #186

Merged
merged 6 commits into from
Jun 19, 2018
Merged

Various TLS & Sync related fixes #186

merged 6 commits into from
Jun 19, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Jun 18, 2018 •
edited
Loading

This PR contains various fixes:

  • Altnames are no longer stored in CA certificates, only in TLS server certificates
  • WaitForMemberUp now works for arangosync members
  • spec.sync.externalAccess.accessPackageSecretNames is now correct. Used to be ...AccessPackageSecretNames
  • ArangoDeploymentReplication field endpoint is now called masterEndpoint for consistency

@ewoutp ewoutp self-assigned this Jun 18, 2018
@ewoutp ewoutp mentioned this pull request Jun 18, 2018
Merged
@ewoutp ewoutp requested a review from neunhoef June 18, 2018 15:17
neunhoef
neunhoef approved these changes Jun 19, 2018
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit ee52f80 into master Jun 19, 2018
@ewoutp ewoutp deleted the bugfix/tls-and-sync-fixes branch June 19, 2018 07:25
@ewoutp ewoutp removed the 4 - Review label Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees

@ewoutp ewoutp

Labels
Team Clifton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @neunhoef