Break PKS Loop #277
Merged
Break PKS Loop #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
neunhoef
requested changes
Oct 26, 2018
neunhoef
reviewed
Oct 31, 2018
| return false | ||
| } | ||
|
|
||
| for i := 0; i < len(cl); i++ { |
There was a problem hiding this comment.
Might have to ignore the order.
| func (c Condition) Equal(other Condition) bool { | ||
| return c.Type == other.Type && | ||
| c.Status == other.Status && | ||
| c.LastUpdateTime.Time.Sub(other.LastUpdateTime.Time).Seconds() < 2 && |
There was a problem hiding this comment.
Use a function for time comparison. Also make sure we do not have to take the absolute value.
| ds.Reason == other.Reason && | ||
| ds.ServiceName == other.ServiceName && | ||
| ds.SyncServiceName == other.SyncServiceName && | ||
| reflect.DeepEqual(ds.Images, other.Images) && |
There was a problem hiding this comment.
Get rid of DeepEqual altogether round here.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check more carefully if an update is required to prevent update loops on PKS <3