Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set write_async to False by default #77

Merged
merged 2 commits into from
Mar 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nx_arangodb/classes/digraph.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class DiGraph(Graph, nx.DiGraph):
Used for inserting node and edge data into the database if and only if
**incoming_graph_data** is a NetworkX graph.

write_async : bool (optional, default: True)
write_async : bool (optional, default: False)
Whether to insert data into ArangoDB asynchronously. Used for inserting
node and edge data into the database if and only if **incoming_graph_data**
is a NetworkX graph.
Expand Down Expand Up @@ -157,7 +157,7 @@ def __init__(
read_parallelism: int = 10,
read_batch_size: int = 100000,
write_batch_size: int = 50000,
write_async: bool = True,
write_async: bool = False,
symmetrize_edges: bool = False,
use_arango_views: bool = False,
overwrite_graph: bool = False,
Expand Down
2 changes: 1 addition & 1 deletion nx_arangodb/classes/function.py
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,7 @@ def separate_nodes_by_collections(


def transform_local_documents_for_adb(
original_documents: dict[str, Any]
original_documents: dict[str, Any],
) -> list[dict[str, Any]]:
"""Transform original documents into a format suitable for UPSERT
operations in ArangoDB. Returns a list of documents with '_key' attribute
Expand Down
4 changes: 2 additions & 2 deletions nx_arangodb/classes/graph.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ class Graph(nx.Graph):
Used for inserting node and edge data into the database if and only if
**incoming_graph_data** is a NetworkX graph.

write_async : bool (optional, default: True)
write_async : bool (optional, default: False)
Whether to insert data into ArangoDB asynchronously. Used for inserting
node and edge data into the database if and only if **incoming_graph_data**
is a NetworkX graph.
Expand Down Expand Up @@ -191,7 +191,7 @@ def __init__(
read_parallelism: int = 10,
read_batch_size: int = 100000,
write_batch_size: int = 50000,
write_async: bool = True,
write_async: bool = False,
symmetrize_edges: bool = False,
use_arango_views: bool = False,
overwrite_graph: bool = False,
Expand Down
4 changes: 2 additions & 2 deletions nx_arangodb/classes/multidigraph.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ class MultiDiGraph(MultiGraph, DiGraph, nx.MultiDiGraph):
Used for inserting node and edge data into the database if and only if
**incoming_graph_data** is a NetworkX graph.

write_async : bool (optional, default: True)
write_async : bool (optional, default: False)
Whether to insert data into ArangoDB asynchronously. Used for inserting
node and edge data into the database if and only if **incoming_graph_data**
is a NetworkX graph.
Expand Down Expand Up @@ -168,7 +168,7 @@ def __init__(
read_parallelism: int = 10,
read_batch_size: int = 100000,
write_batch_size: int = 50000,
write_async: bool = True,
write_async: bool = False,
symmetrize_edges: bool = False,
use_arango_views: bool = False,
overwrite_graph: bool = False,
Expand Down
4 changes: 2 additions & 2 deletions nx_arangodb/classes/multigraph.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class MultiGraph(Graph, nx.MultiGraph):
Used for inserting node and edge data into the database if and only if
**incoming_graph_data** is a NetworkX graph.

write_async : bool (optional, default: True)
write_async : bool (optional, default: False)
Whether to insert data into ArangoDB asynchronously. Used for inserting
node and edge data into the database if and only if **incoming_graph_data**
is a NetworkX graph.
Expand Down Expand Up @@ -169,7 +169,7 @@ def __init__(
read_parallelism: int = 10,
read_batch_size: int = 100000,
write_batch_size: int = 50000,
write_async: bool = True,
write_async: bool = False,
symmetrize_edges: bool = False,
use_arango_views: bool = False,
overwrite_graph: bool = False,
Expand Down