Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE-701 | CodeCov Orb in CircleCI #301

Merged
merged 9 commits into from
Jan 11, 2024
Merged

DE-701 | CodeCov Orb in CircleCI #301

merged 9 commits into from
Jan 11, 2024

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Nov 24, 2023

@aMahanna
Copy link
Member Author

aMahanna commented Nov 24, 2023

Apparently CodeCov has "automatic" coverage merging, so this task may be simpler than we originally thought: https://docs.codecov.com/docs/merging-reports

Will have to first enable 3rd party Orbs before proceeding Done

@aMahanna aMahanna changed the title DE-701 | CodeCov Orb in CircleCI wip: DE-701 | CodeCov Orb in CircleCI Nov 24, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (744a6e9) 99.01% compared to head (b5a4c4f) 98.12%.
Report is 30 commits behind head on main.

Files Patch % Lines
arango/client.py 40.00% 6 Missing ⚠️
arango/collection.py 95.32% 5 Missing ⚠️
arango/database.py 92.95% 5 Missing ⚠️
arango/connection.py 84.61% 4 Missing ⚠️
arango/cluster.py 96.96% 1 Missing ⚠️
arango/resolver.py 96.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   99.01%   98.12%   -0.89%     
==========================================
  Files          26       26              
  Lines        3958     4272     +314     
==========================================
+ Hits         3919     4192     +273     
- Misses         39       80      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aMahanna aMahanna added the Ready to Merge Pull request is ready to merge label Dec 15, 2023
@aMahanna
Copy link
Member Author

CodeCov seems to be working with CircleCI now, we can revisit their "full functionality" upgrade later on:
image

@aMahanna aMahanna changed the title wip: DE-701 | CodeCov Orb in CircleCI DE-701 | CodeCov Orb in CircleCI Dec 15, 2023
@CryptoNinjaGeek CryptoNinjaGeek merged commit 99f5d9b into main Jan 11, 2024
@CryptoNinjaGeek CryptoNinjaGeek deleted the DE-701 branch January 11, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to Merge Pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants